Don't omit 'inputs' field in pagerduty_incident_workflow as it's required by the API#163
Merged
imjaroiswebdev merged 1 commit intoheimweh:masterfrom Mar 19, 2025
Merged
Conversation
imjaroiswebdev
approved these changes
Mar 19, 2025
Collaborator
imjaroiswebdev
left a comment
There was a problem hiding this comment.
@tganderson0 thank you very much for finding and patching this. 🏆
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the client omits fields that are empty when serializing to JSON. However, the API endpoint
https://api.pagerduty.com/incident_workflows/id, which is used for updating Incident Workflows, requires that the fieldinputsexists in the payload. This makes it so that you cannot use the create zoom room action (or any others that do not have an input) without a 'fake' input.This also addresses the issue in PagerDuty/terraform-provider-pagerduty#840
API Response without the inputs defined
This is copied from my PR in the terraform provider which uses this client- PagerDuty/terraform-provider-pagerduty#992.